Remove github.com/grpc-ecosystem/grpc-gateway unused dependency #2858
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffy-mathew
changed the title
Codecov Report
@@ Coverage Diff @@
## master #2858 +/- ##
==========================================
+ Coverage 95.93% 95.94% +0.01%
==========================================
Files 223 223
Lines 9675 9675
==========================================
+ Hits 9282 9283 +1
+ Misses 325 323 -2
- Partials 68 69 +1
Continue to review full report at Codecov.
|
jeffy-mathew
force-pushed
the
remove-grpc-gateway-dependency
branch
from
dc1965f
to
0fa13bc
Compare
Signed-off-by: Jeffy Mathew <jeffy.mathew100@gmail.com>
Signed-off-by: Jeffy Mathew <jeffy.mathew100@gmail.com>
jeffy-mathew
force-pushed
the
remove-grpc-gateway-dependency
branch
from
0fa13bc
to
9cddac3
Compare
|
@joe-elliott I wonder if this would any effect on your proto upgrade, since it explicitly removes registrations against official goproto in the generated files. |
This was referenced Mar 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jeffy Mathew jeffy.mathew100@gmail.com
Which problem is this PR solving?
Short description of the changes